Shadow's Workshop

It does not mather what this does, the fact that it has php and javascript code all bunched up into one file is enough to make me hurl.

<?php
$maxopts = array();
foreach($post['pagestats'] as $ppage=>$qpage) {?>
taguchi_webpage['<?=$ppage?>'] = base64Decode("<?=$qpage['webpage']?>");
taguchi_factors['<?=$ppage?>'] = new Array();
testtype['<?=$ppage?>'] = <?=$qpage['mainhistory']['testtype']?>;
select_factor['<?=$ppage?>']=new Array();
for(i=0;i<20;i++)
select_factor['<?=$ppage?>'][i] = 0;
<?$maxopts[$ppage]=0;
for($i=0;$i<$qpage['taguchi_test']['factors'];$i++){?>
taguchi_factors['<?=$ppage?>'][<?=$i?>]=new Array();
<?/*pt. fiecare regiune a factorului i*/?>
<?for($r=0;$r<count($qpage['taguchi_test_options'][$i]);$r++){?>
taguchi_factors['<?=$ppage?>'][<?=$i?>][<?=$r?>]=new Array();
<?$mm = 0;
  for($k=0;$k<$qpage['taguchi_test']['levels'][$i];$k++){?>
<?/*factorul i regiunea r optiunea k*/
if(strlen($qpage['taguchi_test_options'][$i][$r]['option'.($k+1)])!==0)
$mm ++;
?>
taguchi_factors['<?=$ppage?>'][<?=$i?>][<?=$r?>][<?=$k?>]=base64Decode("<?=$qpage['taguchi_test_options'][$i][$r]['option'.($k+1)]?>");
<?}
if($mm>$maxopts[$ppage])
$maxopts[$ppage]=$mm;
?>
<?}?>
<?}
if($maxopts[$ppage]<=1)
$maxopts[$ppage] = 2;
}?>

I could not believe this piece of code right here.

if(i==0) cc="A";
if(i==1) cc="B";
if(i==2) cc="C";
if(i==3) cc="D";
if(i==4) cc="E";
if(i==5) cc="F";
if(i==6) cc="G";
if(i==7) cc="H";
if(i==8) cc="I";
if(i==9) cc="J";
if(i==10) cc="K";
if(i==11) cc="L";
if(i==12) cc="M";
if(i==13) cc="N";
if(i==14) cc="O";

Hm...i agree...we really need an array of true...just in case we forget it's value.

 $valid_opts = array(true,true,true,true,true,true,true,true,true,true);

An error handler for php works best if i just tell it to ignore the errors i already know about.

function user_error_handler($severity, $msg, $filename, $linenum) { 
      if(strpos($msg,"Undefined index:")!==false) 
      return; 
      if(strpos($msg,"Undefined variable:")!==false) 
      return; 
      if(strpos($msg,"Assigning the return value of new by reference is deprecate")!==false) 
      return; 
      if(strpos($msg,"is_a():")!==false) 
      return; 
      if(strpos($msg,"not safe to rely on the system's timezone settings")!==false) 
      return; 
      debug($msg." - {$filename} - {$linenum}", "err"); 
 }

Okey let's not use the body of the if statment, it's much easier to use the else statment instead of turning the condition into a negation.

if(preg_match('/(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})/',$domain) || strrpos($domain,".")===false){} else {
           if($lasttld)
                $domain = substr($domain,strrpos($domain,'.')+1);
      }

the php manual says it the best

This helps prevent poorly written scripts for eating up all available memory on a server.

 ini_set('memory_limit', '100M');

That's about it for now, i do not know why i have a feeling that more gems are just waiting to be discovered. Feel free to add your own findings in the comments.