Sitepatching updates

tweaking the broken code until it works, one site at a time

Cleaning after Ragnarök

By Ola P. Kleivenolak. Tuesday, October 11, 2011 8:44:16 AM

A long log this time, so I'll split it into several sections.

First the things common to O11- and O12-files
Added patches

PATCH-517, docs.google: make document names visible. Core issue where a table with fixed layout and cells with total width exceeding table width pushes content out of view. Somewhat unspecified territory but Opera is the odd one out, so we'll have to align here at some point. Same thing that broke the apple.com menus.

PATCH-516, infojobs.com.br: unwrap input elements. The button has a margin-right of 0.1em. Opera calulates this to 2px due to imprecise rounding and ends up with slightly too wide content that wraps. Basic issue is up for fixing, but won't make it into O12.

Removed patches
PATCH-87, Downloading documents on salesforce.com runs into too strict anti-drive-by-install security (Core fix)

Additional changes in 12-file
Presto/2.9.220 introduces the new parser, but other Core developers have been busy fixing stuff too.

Removed patches due to normal Core fixes
PATCH-479, capital.gr: avoid unintentional XHR abort() calls.

PATCH-454, No closure for eval'ed function expression means no way to close info box on Google Maps.

PATCH-441, Script sets window.event manually for other events but not for (all) click events, breaks attachment download on Hotmail.

PATCH-361, Avoid too tall content on AOL.

PATCH-331, Disable HTMLElement.removeNode support. This was a compat experiment with no side effects, so we have removed support in Core.

PATCH-329, Disable Node.document support, breaks shimano.com menu. Also had some side effect in some jQuery-versions.

PATCH-303, Reporting different clientHeight and scrollHeight for TEXTAREA breaks commenting on nfl.com

Removed patches due to Ragnarök fixes
PATCH-463, Fix misnested markup on FlyTap

PATCH-462, 56.com - fix missing video comments

PATCH-444, Make Twitter hashtags visible due to misnested elements.

PATCH-366, Fix unclickable credit card selection box on PayPal.

PATCH-311, Hotmail hidden 'next page' links due to markup errors


Removed patches due to site changes
Since Yahoo! have now phased in the latest Y!Mail version, we are retiring a bunch of patches that applied to the old one. It's hard to test all aspects of a site like this, so we're removing these from O12-file only for now. Please yell if you find something to be broken after this.

CORE-17539, Y!Mail spell check fix

CORE-17538, Y!Mail avoid text selection on drag-and-drop

353880, Y!Mail reversed mouse wheel scrolling

327060, Shadow on dialogs is messed up, so fix it

321384, createElement in XML document should put un-prefixed nodes in null namespace

194334, Make sure dragging does not cause visible selections

194334, Y!Mail remove selectSingleNode and selectNodes

Yahoo!, Yammer, YouTubeBlogger, blogger, blogger

Comments

ouzowtfouzoWTF Tuesday, October 11, 2011 10:40:54 AM

up up up up up

Hallvord R. M. Steenhallvors Tuesday, October 11, 2011 11:02:48 AM

A stunning cleanup. The number of active patches dropped to 160 smile.

Note that the backend does not try to distinguish the Opera 12 previews that have the Ragnarök HTML5 parser and those that don't as far as I know. We could do that, but it doesn't seem worthwhile. So if you're using an Opera 12 older than the latest snapshot, you'll miss a handful patches that are actually required.

Daniel HendrycksDanielHendrycks Tuesday, October 11, 2011 12:39:05 PM

up

Galileo Tuesday, October 11, 2011 2:25:57 PM

Is the new file up because i can't download the new version. It stays with the October 4, 2011.

Ola P. Kleivenolak Tuesday, October 11, 2011 2:39:44 PM

Works here, but there has been some issues with mirror syncing lately.

ouzowtfouzoWTF Tuesday, October 11, 2011 4:03:15 PM

The smileys here in the comments look a bit strange with O12 1090. Is it only me? Can somebody confirm that? http://files.myopera.com/ouzoWTF/files/strangesmileys.png

Galileo Tuesday, October 11, 2011 4:44:04 PM

Originally posted by ouzoWTF:

The smileys here in the comments look a bit strange with O12 1090. Is it only me? Can somebody confirm that? http://files.myopera.com/ouzoWTF/files/strangesmileys.png


They are lol, an hour or so ago that i refreshed the page to check for new comments it wasn't like this. *And after i edit my post to correct a word they are back to normal smile its not just this blog, they migrated here http://my.opera.com/chooseopera/blog/2011/10/11/highlights-of-up-north-web

ouzowtfouzoWTF Tuesday, October 11, 2011 6:02:33 PM

Now they look fine again bigeyes

Another thing: Is anybody using xEraths userscript for myopera comments? The text area gets longer with every character I type :/

Jimtoyotabedzrock Tuesday, October 11, 2011 6:37:35 PM

Will the rounding fix make it into Opera 12.5?

Charles SchlossChas4 Wednesday, October 12, 2011 12:53:42 PM

Target version and time stamp of the active browser.js file is Opera Desktop 11.50 core 2.9.168, October 11, 2011. Active patches: 184 .

up

Ola P. Kleivenolak Wednesday, October 12, 2011 2:32:38 PM

Jim: 12.50? You're way ahead of me - I don't even know when that is due wink We have recently started work, so I hope it will.

ouzowtf: that's related to the fix that obsoleted PATCH-303. Pasting the resize-code into a document shows that Presto now does the same as Gecko/WebKit.

About the "Active patches" counter - we found a little bug, so next update will show a somewhat different number. Just a heads up.

ouzowtfouzoWTF Wednesday, October 12, 2011 3:51:22 PM

Originally posted by olak:

ouzowtf: that's related to the fix that obsoleted PATCH-303. Pasting the resize-code into a document shows that Presto now does the same as Gecko/WebKit.


So when I understand correct, then this behavior should not happen with the newest browserjs, right?
But I still see only
Target version and time stamp of the active browser.js file is Opera Desktop 12.00 core 2.9.211, October 4, 2011. Active patches: 170 .

O12 1090

sad

Ola P. Kleivenolak Wednesday, October 12, 2011 5:42:17 PM

browser.js does not affect this at all. However, PATCH-303 was for a bug dealing with scrollHeight on textareas. We then fixed CORE-32850 and was able to drop PATCH-303 (which was for a specific site). But, xErath's script depends on the old scrollHeight of textarea behavior (padding not part of scrollHeight) so each keystroke adds a bit too much height in the calculation.

ouzowtfouzoWTF Wednesday, October 12, 2011 10:59:00 PM

Ahh, now I understand it. But the problem with the not up to date browserjs is still there worried

Ola P. Kleivenolak Thursday, October 13, 2011 7:52:33 AM

Yes, upgrading some data centers caused some oddity with syncing scripts. Working on it.

ouzowtfouzoWTF Thursday, October 13, 2011 9:22:02 AM

Originally posted by olak:

Yes, upgrading some data centers caused some oddity with syncing scripts. Working on it.


Thanks for that information.

Galileo Sunday, October 16, 2011 9:47:36 AM

Now its ok: Target version and time stamp of the active browser.js file is Opera Desktop 12.00 core 2.9.220, October 11, 2011. Active patches: 160

About yahoo, is there a bug report about not being able to open a chat contact to chat? When i click one i get this in the error console:
Event thread: load
Uncaught exception: ReferenceError: Security error: attempted to read protected variable: getComputedStyle
Error thrown at line 964, column 6 in <anonymous function>(e):
gCS=ifrWin.getComputedStyle;
I'll try to make one later in the day just in case.

Jimtoyotabedzrock Monday, October 17, 2011 8:58:46 PM

The hash symbol on some Twitter hashtags still disappears.
Look at this twitter feed for #youneedtoknowthis http://twitter.com/#!/Thom_Hartmann

You will notice in some instances it is not visible.

Charles SchlossChas4 Monday, October 17, 2011 10:01:59 PM

Something wrong server side?

Target version and time stamp of the active browser.js file is Opera Desktop 11.50 core 2.9.168, October 4, 2011. Active patches: 184 .



Is what I am seeing today after a check for updates

Ola P. Kleivenolak Tuesday, October 18, 2011 6:07:15 AM

Yes, very broken.

Ola P. Kleivenolak Tuesday, October 18, 2011 8:29:43 AM

Jim: yes, fixed internally.

Write a comment

New comments have been disabled for this post.