Sitepatching updates

tweaking the broken code until it works, one site at a time

web.de, 4chan, GMail

By Ola P. Kleivenolak. Monday, February 13, 2012 4:20:00 PM

Added patches
PATCH-586, web.de: hide browser "upgrade" message.

PATCH-585, 4chan: add bottom margin to blockquote for better readability. A quirk IE and Opera have causes vertical margins to collapse. Re-introduce them.

PATCH-582, GMail: override workaround for old font-size bug in Opera. We fixed a bug in 11.60 and now the GMail compose font is too small because they coded for our old behavior. Patch while we wait.

Changed patches
PATCH-517, docs.google: make document names visible. Now even when toggling selection.

PATCH-372, Work around Facebook's attachEvent usage in all.js. Moved code to separate event listener to be able to version it better according to recent attachEvent core changes.

Removed patches
PATCH-551, Keep document.domain in sync inside IFRAME and main document on eBay. Site changed.

PATCH-516, infojobs.com.br: unwrap input elements. Site changed.

PATCH-422, Miscalculated IFRAME height prevents booking on rede-expressos. Site changed.

352969, Make Opera's built-in WF2 validation ignore required attributes on ingdirect.com.au Site changed after other browsers implemented "required" attribute too.

Changes to 12.00 file only
removed PATCH-536, renren.com - Unicode space like characters should not be converted in document.title. Core fix.

removed PATCH-506, YouTube: avoid Silverlight uploader. As of Presto/2.10.246 Opera supports XHR2 upload attribute and progress events which should make native uploader available on Google, voiding the need to avoid Silverlight.

removed PATCH-497, Avoid focus problems using IME on empty content-editable elements on qq.com. Core fix.

removed PATCH-464, Make it possible to type in TomTom route planner. Core fix.

added PATCH-571, live.com: make file names visible. A Core bug fix removed a quirk that unfortunately live.com depends on.

window.event, attachEvent, detachEvent, script.onreadystatechangeWeibo, SoftBank, Twitter, GMail again

Comments

d4rkn1ght Monday, February 13, 2012 4:40:01 PM

up

andol Monday, February 13, 2012 8:34:48 PM

I have these patches in Opera Next and latest stable Opera (11.61 build 1250), but Opera 11.62 build 1302 still reports

Target version and time stamp of the active browser.js file is Opera Desktop 11.60 core 2.10.229, January 30, 2012. Active patches: 178.

(Yes, I checked for updates manually.)

Ned the NaniteNedTheNanite Tuesday, February 14, 2012 7:27:56 AM

I've got the patch dated 13 February 2012 but it hasn't fixed Gmail. I still see the small font. sad

Ola P. Kleivenolak Tuesday, February 14, 2012 8:19:18 AM

@andol: yes, there is a special treat for 11.62 users coming wink

@Ned: strange. Do you run a special theme or similar? The patch works on the body classname the editable iframe, so if you for some reason get a version that has different classname there it may fail. The patch is is currently 
body.editable.LW-avf{font-size: small}


Anyone else still seeing this problem?

ouzowtfouzoWTF Tuesday, February 14, 2012 8:27:16 AM

Originally posted by sitepatching:

We fixed a bug in 11.60 and now the GMail compose font is too small because they coded for our old behavior.


Seems like the communication could be better between Opera and Google wink

Since this morning I dont get a css-file on http://my.opera.com/ENTERYOURUSERNAME/news/
(using latest 11.62 snapshot)

StefanZwoks-Stef Tuesday, February 14, 2012 9:18:08 AM

PATCH-586 doesn't work for me.
It hides the message but the content is displayed in two little iframes.

They used to extend when I clicked on "Nein Danke" in the message.

Ola P. Kleivenolak Tuesday, February 14, 2012 9:37:22 AM

@Stefan: I've seen it too, but it is very hard to reproduce (we have an old bug report or two about it as well, so it is not a new problem) Does it always happen for you?

The patch is not for that problem anyway, it is only to hide the message.

Christophchristoph142 Tuesday, February 14, 2012 9:43:37 AM

voiding the need to avoid Silverlight


That's a bit of a double-negotiation, isn't it? wink

And thanks for making that web.de-message go away. My mum always asked me, if she's supposed to click on there.
But are you aware, that gmx.de/gmx.net is displaying a similar message? (web.de & gmx belong together and do have the same bar up there so the web.de-patch should more or less do its job on gmx.de as well without big adjustments)

eliotcougar Tuesday, February 14, 2012 11:12:19 AM

Originally posted by olak:

@Ned: strange. Do you run a special theme or similar? The patch works on the body classname the editable iframe, so if you for some reason get a version that has different classname there it may fail. The patch is is currently 

body.editable.LW-avf{font-size: small}


Anyone else still seeing this problem?


Somehow, Opera does not apply CSS style to that classname until you reload the email compose window...

Click New email – No custom CSS applied, font size is "x-small"
Press F5 – Custom CSS applied and font size is "small"

Ola P. Kleivenolak Tuesday, February 14, 2012 11:37:08 AM

@Christoph - ok, will look into that. Somehow none of our testaccounts seem to work and I'm not allowed to sign up for a new one (technical difficulties) right now.

@eliotcougar - right, could be timing. Always works here though. I'll try add !important to it in case it is sometimes added before the other inline style.

Çağlar Yeşilyurtgreench Tuesday, February 14, 2012 11:51:10 AM

@ola
PATCH-582 is not working for me(Opera Desktop 12.00 core 2.10.255, February 13, 2012. Active patches: 172). Opera shows
td .LW-avf{font-size: x-small}

Ola P. Kleivenolak Tuesday, February 14, 2012 1:08:32 PM

Do you have one or two style elements in the head? If two, which order are they?

Çağlar Yeşilyurtgreench Tuesday, February 14, 2012 1:42:49 PM

Originally posted by olak:

Do you have one or two style elements in the head? If two, which order are they?


I'm sorry I wrote missing. "td, .LW-avf" Inherited from body.

StefanZwoks-Stef Tuesday, February 14, 2012 2:49:38 PM

@Ola / PATCH-586: It's working at the moment. Seems to be sporadical.

Charles SchlossChas4 Tuesday, February 14, 2012 5:00:46 PM

Target version and time stamp of the active browser.js file is Opera Desktop 11.60 core 2.10.229, February 13, 2012. Active patches: 178

Originally posted by olak:

there is a special treat


O a comming Thursday nom nom nom

Jimtoyotabedzrock Friday, February 17, 2012 1:04:01 AM

Is it just me or is Google+ now totally broken on Opera?

http://files.myopera.com/Tamil/Smilies/Sad.gif -

Ola P. Kleivenolak Friday, February 17, 2012 10:38:41 AM

Looks fine here, anything specific in mind? (presumably "totally broken" means unusable?)

Cutting Spoonhellspork Monday, February 20, 2012 3:13:45 AM

Deheehe you even patched 4chan. Nice to see popular sites are evenly handled...

toncidamjanic Monday, February 20, 2012 10:11:03 AM

PATCH-582, GMail: override workaround for old font-size bug in Opera. We fixed a bug in 11.60 and now the GMail compose font is too small because they coded for our old behavior. Patch while we wait.



The patch doesn't work in Opera for Mac: Opera/9.80 (Macintosh; Intel Mac OS X 10.6.8; U; en) Presto/2.10.229 Version/11.61

There is no trace of the patch style, although it is applied and traceable in the console log:

Opera has modified the JavaScript on mail.google.com (Google). See browser.js for details


The only style applied to the edit box's <body> element is the default value:

td, .LW-avf { font: x-small "arial"; }

Jimtoyotabedzrock Tuesday, February 21, 2012 3:51:59 PM

Originally posted by olak:

Looks fine here, anything specific in mind? (presumably "totally broken" means unusable?)



It was Opera Next I will have to test with the newer build. The stream was non functional and I couldn't share or comment on anything.

There seems to be some JS problems in Opera Next. The Dart page freezes up if you run an example on Next but not on 11.62.

You should ask them to update the version of Firefox it reports as when changing the useragent. Version 10 is a long term release.

Christophchristoph142 Friday, March 9, 2012 11:25:52 AM

Did you see, that web.de has changed its interface completely?
Not sure if that upgrade message would still be visible without the browser.js
Maybe you can check it out wink

Ola P. Kleivenolak Friday, March 9, 2012 11:44:22 AM

thx, willl do

Ola P. Kleivenolak Friday, March 9, 2012 12:32:39 PM

Looks like it works fine without patch.

Christophchristoph142 Friday, March 9, 2012 1:25:21 PM

Originally posted by olak:

Looks like it works fine without patch.


Nice smile Thx for the feedback (although I'm not using web.de myself)

Write a comment

New comments have been disabled for this post.